-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Limit tree output #128290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Limit tree output #128290
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
@idegtiarenko shouldn't And anyway, how hard would it be to just fix it in |
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/Project.java
Show resolved
Hide resolved
It looks like that however it is actually not solving this issue (as you can see the plan still contains very long output). elasticsearch/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/tree/Node.java Lines 419 to 427 in 7d466c9
it only inserts \n once if the last stringValue makes the line longer than the limit.It does not trim output nor break the line multiple times.
I would prefer to fix 2 affected places for now. Generic one could be fixed later that would also allow us remove all custom nodeString implementation. Probably it is worth doing it if we decide to implement |
|
It looks to me like Wouldn't it be nicer to detect this case inside Edit: |
Today the output of attribute list is not limited in any way.
This results in a following tree when running wide schema benchmark with trace logging enabled:
Logs
I had to manually truncate the output as github was complaining that pr description is >= 65kb with 2500 attributes listed twice in the tree (in _ExchangeExec and in Project).
Ideally we should handle that while building generic property but for now this limits output of the ones I noticed.